[webkit-reviews] review denied: [Bug 185244] [EME][GStreamer] Crash when the mediaKeys are created before loading the media in debug conf : [Attachment 339501] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 185244: [EME][GStreamer] Crash when the mediaKeys are created before
loading the media in debug conf
https://bugs.webkit.org/show_bug.cgi?id=185244

Attachment 339501: Patch

https://bugs.webkit.org/attachment.cgi?id=339501&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 339501
  --> https://bugs.webkit.org/attachment.cgi?id=339501
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339501&action=review

> Source/WebCore/ChangeLog:11
> +	   to the MediaPlayerPrivate via
"MediaPlayerPrivateGStreamerBase::cdmInstanceAttached" before laoding

loading

>>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1222
>> +	if (m_cdmInstance.get() == &instance) {
> 
> .get() required here?

It looks like it is not. Besides, I don't think this chunk of code is necessary
as detach is not called multiple times as attach is. Unless you think I am
wrong, please remove this chunk and leave the code as it was.