[webkit-reviews] review granted: [Bug 181855] [EME][GStreamer] Move the decryptor from AppendPipeline to PlaybackPipeline. : [Attachment 339486] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 7 00:29:02 PDT 2018
Xabier RodrÃguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 181855: [EME][GStreamer] Move the decryptor from AppendPipeline to
PlaybackPipeline.
https://bugs.webkit.org/show_bug.cgi?id=181855
Attachment 339486: Patch
https://bugs.webkit.org/attachment.cgi?id=339486&action=review
--- Comment #19 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 339486
--> https://bugs.webkit.org/attachment.cgi?id=339486
Patch
It looks ok, but my only concern is whether tests are going to break again
because protection events are not forwarded to the PlaybackPipeline. I wouldn't
like to roll out this patch again because of that.
More information about the webkit-reviews
mailing list