[webkit-reviews] review granted: [Bug 185353] Text track cue logging should include cue text : [Attachment 339667] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185353: Text track cue logging should include cue text
https://bugs.webkit.org/show_bug.cgi?id=185353

Attachment 339667: Patch

https://bugs.webkit.org/attachment.cgi?id=339667&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 339667
  --> https://bugs.webkit.org/attachment.cgi?id=339667
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339667&action=review

> Source/WebCore/html/track/VTTCue.h:180
> +    void toJSON(JSON::Object&) const final;

Could be made private maybe?

> Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h:123
> +    object->setString("text", m_content);

ASCIILiteral?

> Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp:117
> +    object->setString(ASCIILiteral("text"), m_cueText);

Should it be "cueText"? Similarly for "text" -> "content" above maybe?