[webkit-reviews] review granted: [Bug 185357] [LFC] Add assertions for stale Display::Box geometry : [Attachment 339669] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185357: [LFC] Add assertions for stale Display::Box geometry
https://bugs.webkit.org/show_bug.cgi?id=185357

Attachment 339669: Patch

https://bugs.webkit.org/attachment.cgi?id=339669&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 339669
  --> https://bugs.webkit.org/attachment.cgi?id=339669
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339669&action=review

> Source/WebCore/layout/displaytree/DisplayBox.h:138
> +#if !ASSERT_DISABLED
> +    bool m_hasValidTop : 1;
> +    bool m_hasValidLeft : 1;
> +    bool m_hasValidWidth : 1;
> +    bool m_hasValidHeight : 1;
> +    bool m_hasValidMargin : 1;
> +    bool m_hasValidBorder : 1;
> +    bool m_hasValidPadding : 1;
> +#endif

I would just use bools. There is no need to optimize memory use of the debug
build.

Do all these really need separate flags?