[webkit-reviews] review granted: [Bug 185356] Draw a drop-shadow behind the system preview badge : [Attachment 339656] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 185356: Draw a drop-shadow behind the system preview badge
https://bugs.webkit.org/show_bug.cgi?id=185356

Attachment 339656: Patch

https://bugs.webkit.org/attachment.cgi?id=339656&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 339656
  --> https://bugs.webkit.org/attachment.cgi?id=339656
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339656&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:1853
> +    RetainPtr<CGPathRef> circle =
adoptCF(CGPathCreateWithRoundedRect(absoluteBadgeRect, badgeDimension / 2,
badgeDimension / 2, nullptr));

Nit - I think we generally auto these.