[webkit-reviews] review granted: [Bug 185288] Release assert in ScriptController::canExecuteScripts via HTMLMediaElement::~HTMLMediaElement() : [Attachment 339514] Speculative fix

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 185288: Release assert in ScriptController::canExecuteScripts via
HTMLMediaElement::~HTMLMediaElement()
https://bugs.webkit.org/show_bug.cgi?id=185288

Attachment 339514: Speculative fix

https://bugs.webkit.org/attachment.cgi?id=339514&action=review




--- Comment #5 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 339514
  --> https://bugs.webkit.org/attachment.cgi?id=339514
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=339514&action=review

r=me with nit.

> Source/WebCore/loader/FrameLoader.cpp:811
> +    if (HTMLMediaElement::isRunningDestructor()) {
> +	   scheduleCheckCompleted();

We could really use an ASSERT_NOT_REACHED() here so that it crashes in debug
builds.