[webkit-reviews] review granted: [Bug 185310] Wasted time dlopening Lookup when tearing down a WKWebView : [Attachment 339569] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 185310: Wasted time dlopening Lookup when tearing down a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=185310

Attachment 339569: Patch

https://bugs.webkit.org/attachment.cgi?id=339569&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 339569
  --> https://bugs.webkit.org/attachment.cgi?id=339569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339569&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:293
> +    _didRegisterForLookupPopoverCloseNotifications = true;

Nit - _didRegisterForLookupPopoverCloseNotifications = YES; (or bool
_didRegisterForLookupPopoverCloseNotifications)