[webkit-reviews] review requested: [Bug 185054] REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line : [Attachment 339568] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 185054: REGRESSION (r229955): run-webkit-tests runs tests in skipped
directories and subdirectories of directory given on command line
https://bugs.webkit.org/show_bug.cgi?id=185054

Attachment 339568: Patch

https://bugs.webkit.org/attachment.cgi?id=339568&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Created attachment 339568

  --> https://bugs.webkit.org/attachment.cgi?id=339568&action=review

Patch

I did not write a test because the port's OS version is a private field as it
represents an implementation detail and I did not feel the risk of regression
was great enough to justify exposing this detail. Moreover, I was unclear how I
could indirectly test this change by way of
MacPort.default_baseline_search_path().