[webkit-reviews] review granted: [Bug 185301] [LFC] Set the invalidation root as the result of style change. : [Attachment 339544] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 4 08:13:26 PDT 2018
Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185301: [LFC] Set the invalidation root as the result of style change.
https://bugs.webkit.org/show_bug.cgi?id=185301
Attachment 339544: Patch
https://bugs.webkit.org/attachment.cgi?id=339544&action=review
--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 339544
--> https://bugs.webkit.org/attachment.cgi?id=339544
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=339544&action=review
> Source/WebCore/layout/inlineformatting/InlineInvalidation.h:46
> - static void invalidate(const Box&, StyleDiff, LayoutContext&,
InlineFormattingState&);
> + static const Container* invalidate(const Box&, StyleDiff,
LayoutContext&, InlineFormattingState&);
It is bit unclear what the return value is here. Maybe
'invalidateAndComputeRoot' or something? Or just a comment.
More information about the webkit-reviews
mailing list