[webkit-reviews] review granted: [Bug 185281] OSR entry pruning of Program Bytecodes doesn't take into account try/catch : [Attachment 339497] Updated Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 3 17:50:29 PDT 2018
Saam Barati <sbarati at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 185281: OSR entry pruning of Program Bytecodes doesn't take into account
try/catch
https://bugs.webkit.org/show_bug.cgi?id=185281
Attachment 339497: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=339497&action=review
--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339497
--> https://bugs.webkit.org/attachment.cgi?id=339497
Updated Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=339497&action=review
r=me
> Source/JavaScriptCore/jit/JIT.cpp:203
> +
please delete.
> Source/JavaScriptCore/jit/JIT.cpp:228
> + for (unsigned bytecodeOffset = block->leaderOffset();
bytecodeOffset < block->leaderOffset() + block->totalLength();) {
Can we skip this loop if the program has no catch handlers?
More information about the webkit-reviews
mailing list