[webkit-reviews] review granted: [Bug 185279] Deprecate legacy WebView and friends : [Attachment 339492] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 17:32:58 PDT 2018


Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 185279: Deprecate legacy WebView and friends
https://bugs.webkit.org/show_bug.cgi?id=185279

Attachment 339492: Patch

https://bugs.webkit.org/attachment.cgi?id=339492&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 339492
  --> https://bugs.webkit.org/attachment.cgi?id=339492
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339492&action=review

> Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:30
> +// Declare this as a system header to avoid WebView deprecation
> +// warnings in this header when building Safari locally.

This feels like a weird comment to have in a private header but there are other
weird comments below so whatever.


More information about the webkit-reviews mailing list