[webkit-reviews] review denied: [Bug 185159] Use default std::optional if it is provided : [Attachment 339489] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185159: Use default std::optional if it is provided
https://bugs.webkit.org/show_bug.cgi?id=185159

Attachment 339489: Patch

https://bugs.webkit.org/attachment.cgi?id=339489&action=review




--- Comment #43 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 339489
  --> https://bugs.webkit.org/attachment.cgi?id=339489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339489&action=review

> Source/WTF/wtf/Optional.h:54
> +#if !COMPILER(MSVC) && !COMPILER(CLANG) && __has_include(<optional>)
> +# include <optional>
> +#endif
> +
> +#if !COMPILER(MSVC) && !COMPILER(CLANG) && defined(__cpp_lib_optional) &&
__cpp_lib_optional >= 201603

I hesitate to r- a patch that's going to fix the build for me personally, but
this is still going to be broken with Clang and that's not OK.