[webkit-reviews] review granted: [Bug 185270] Make it easy to log compile times for all optimizing tiers : [Attachment 339471] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 3 15:00:11 PDT 2018
Keith Miller <keith_miller at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 185270: Make it easy to log compile times for all optimizing tiers
https://bugs.webkit.org/show_bug.cgi?id=185270
Attachment 339471: the patch
https://bugs.webkit.org/attachment.cgi?id=339471&action=review
--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 339471
--> https://bugs.webkit.org/attachment.cgi?id=339471
the patch
View in context: https://bugs.webkit.org/attachment.cgi?id=339471&action=review
r=me.
> Source/JavaScriptCore/Sources.txt:710
> +runtime/CompilerTimingScope.cpp
This is kinda unrelated but I kinda feel like we should have a utilities
directory or something. CompilerTimingScope doesn't feel very runtimey.
More information about the webkit-reviews
mailing list