[webkit-reviews] review granted: [Bug 185218] Strings should not be allocated in a gigacage : [Attachment 339465] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 185218: Strings should not be allocated in a gigacage
https://bugs.webkit.org/show_bug.cgi?id=185218

Attachment 339465: the patch

https://bugs.webkit.org/attachment.cgi?id=339465&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339465
  --> https://bugs.webkit.org/attachment.cgi?id=339465
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339465&action=review

> Source/bmalloc/bmalloc/Gigacage.h:38
>  #define PRIMITIVE_GIGACAGE_SIZE 0x80000000llu
>  #define JSVALUE_GIGACAGE_SIZE 0x40000000llu

Might be worth expanding one (or both) of these