[webkit-reviews] review denied: [Bug 185262] Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set : [Attachment 339463] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 185262: Assertion failure in NetworkStorageSession::setCookie: privilege of
UI process is not set
https://bugs.webkit.org/show_bug.cgi?id=185262

Attachment 339463: Patch

https://bugs.webkit.org/attachment.cgi?id=339463&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339463
  --> https://bugs.webkit.org/attachment.cgi?id=339463
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339463&action=review

> Source/WebKit/ChangeLog:3
> +	   Assertion failure in NetworkStorageSession::setCookie: privilege of
UI process is not set

What assertion? Could you please provide the crash trace on the bug?

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:50
> +    WTF::setProcessPrivileges(allPrivileges());

This should probably inside WebKit::WebSiteDataStore constructor so it works
for C API clients as well, and other APIs that defaultDataStore.