[webkit-reviews] review granted: [Bug 185251] Ads in NYTimes app are shifted downwards by the scroll view's top content inset : [Attachment 339435] Fix OpenSource iOS build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 12:25:40 PDT 2018


Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 185251: Ads in NYTimes app are shifted downwards by the scroll view's top
content inset
https://bugs.webkit.org/show_bug.cgi?id=185251

Attachment 339435: Fix OpenSource iOS build

https://bugs.webkit.org/attachment.cgi?id=339435&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 339435
  --> https://bugs.webkit.org/attachment.cgi?id=339435
Fix OpenSource iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=339435&action=review

> Source/WebKit/UIProcess/Cocoa/VersionChecks.h:41
> +    FirstWhereScrollViewContentInsetsAreNotObscuringInsets =
DYLD_IOS_VERSION_12_0

Probably get that trailing comma in there.


More information about the webkit-reviews mailing list