[webkit-reviews] review denied: [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF : [Attachment 339415] patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 185253: [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=185253

Attachment 339415: patch

https://bugs.webkit.org/attachment.cgi?id=339415&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 339415
  --> https://bugs.webkit.org/attachment.cgi?id=339415
patch

Ooops, one more thing. I notice that ENABLE_TOUCH_EVENTS is actually forced on
in OptionsWPE.cmake:

WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)

If we want to allow disabling touch support, that should be changed from
PRIVATE to PUBLIC, and moved to the list of public options. And Zan should be
the one to approve that.

I guess there's not really any strong reason to support disabling touch events
currently, because it doesn't add any new dependency.