[webkit-reviews] review granted: [Bug 185187] Web Inspector: simplify the WI.Collection interface : [Attachment 339290] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 185187: Web Inspector: simplify the WI.Collection interface
https://bugs.webkit.org/show_bug.cgi?id=185187

Attachment 339290: Patch

https://bugs.webkit.org/attachment.cgi?id=339290&action=review




--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 339290
  --> https://bugs.webkit.org/attachment.cgi?id=339290
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339290&action=review

r=me, nice cleanup

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js:289
> +	       for (let resource of currentFrame.resourceCollection)

Maybe a dumb question, but why isn't the main resource in the resource
collection?

> LayoutTests/http/tests/inspector/network/har/har-page.html:77
> +	       for (let resource of
WI.frameResourceManager.mainFrame.resourceCollection)

You should just push with destructuring, the loop isn't needed here. And
somehow this test is failing on EWS?