[webkit-reviews] review granted: [Bug 185249] [LFC] Box invalidation logic should go to dedicated classes. : [Attachment 339411] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185249: [LFC] Box invalidation logic should go to dedicated classes.
https://bugs.webkit.org/show_bug.cgi?id=185249

Attachment 339411: Patch

https://bugs.webkit.org/attachment.cgi?id=339411&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 339411
  --> https://bugs.webkit.org/attachment.cgi?id=339411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339411&action=review

> Source/WebCore/layout/FormattingState.h:57
> +    enum StateType {
> +	   BlockState,
> +	   InlineState
> +    };

I would go with

enum class Type { Block, Inline }

This is all scoped to FormattingState so repeating word 'State' is redundant.

> Source/WebCore/layout/LayoutContext.h:62
> +    enum UpdateType {

enum class?