[webkit-reviews] review granted: [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF : [Attachment 339408] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 08:53:44 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Pablo Saavedra
<psaavedra at igalia.com>'s request for review:
Bug 185253: [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=185253

Attachment 339408: patch

https://bugs.webkit.org/attachment.cgi?id=339408&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 339408
  --> https://bugs.webkit.org/attachment.cgi?id=339408
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339408&action=review

One more style nit:

> Source/WebKit/Shared/wpe/NativeWebTouchEventWPE.cpp:29
> +#if ENABLE(TOUCH_EVENTS)

Leave one blank line below here...

> Source/WebKit/Shared/wpe/NativeWebTouchEventWPE.cpp:48
> +#endif // ENABLE(TOUCH_EVENTS)

...and one above here.


More information about the webkit-reviews mailing list