[webkit-reviews] review granted: [Bug 185222] Create analysis task should sync analysis task status after creation. : [Attachment 339359] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 185222: Create analysis task should sync analysis task status after
creation.
https://bugs.webkit.org/show_bug.cgi?id=185222

Attachment 339359: Patch

https://bugs.webkit.org/attachment.cgi?id=339359&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339359
  --> https://bugs.webkit.org/attachment.cgi?id=339359
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339359&action=review

> Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:327
> +	   it('should sync the new analysis task status onceit is created',
async () => {

Nit: Need a space between "once" and "it".

> Websites/perf.webkit.org/unit-tests/analysis-task-tests.js:386
> +	   });

Please add another test where the creation of an analysis fails and a rejected
promise is returned (as opposed to throwing an exception).