[webkit-reviews] review granted: [Bug 185138] [Curl] Add OpenSSL/LibreSSL multi-threading support : [Attachment 339353] Fix style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 16:13:53 PDT 2018


Per Arne Vollan <pvollan at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 185138: [Curl] Add OpenSSL/LibreSSL multi-threading support
https://bugs.webkit.org/show_bug.cgi?id=185138

Attachment 339353: Fix style

https://bugs.webkit.org/attachment.cgi?id=339353&action=review




--- Comment #16 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 339353
  --> https://bugs.webkit.org/attachment.cgi?id=339353
Fix style

View in context: https://bugs.webkit.org/attachment.cgi?id=339353&action=review

R=me.

> Source/WebCore/ChangeLog:6
> +	   The older OpenSSL manual says the locking_function and
threadid_funcion should

Small typo, change phrase to 'threadid_function should be set'.

> Source/WebCore/platform/network/curl/CurlSSLHandle.h:74
> +	       static ThreadSupport shared;

I think we can use NeverDestroyed here.


More information about the webkit-reviews mailing list