[webkit-reviews] review granted: [Bug 185205] Can't copy and paste URLs that have no title into Mail (macOS) : [Attachment 339344] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 15:05:26 PDT 2018

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 185205: Can't copy and paste URLs that have no title into Mail (macOS)

Attachment 339344: Patch


--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 339344
  --> https://bugs.webkit.org/attachment.cgi?id=339344

View in context: https://bugs.webkit.org/attachment.cgi?id=339344&action=review

> Source/WebCore/platform/mac/PasteboardMac.mm:202
> -	   paths.append(pasteboardURL.title.stripWhiteSpace());
> +	   paths.append([title stringByTrimmingCharactersInSet:[NSCharacterSet

We should probably just use our stripWhiteSpace, not Cocoa’s. You’re going to
turn it into a String soon anyway, might as well do it before that step and use
more WebKit code.

> Tools/TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:116
> +    urls = [WebURLsWithTitles URLsFromPasteboard: [NSPasteboard

No spaces after colons.

More information about the webkit-reviews mailing list