[webkit-reviews] review granted: [Bug 185205] Can't copy and paste URLs that have no title into Mail (macOS) : [Attachment 339344] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 185205: Can't copy and paste URLs that have no title into Mail (macOS)
https://bugs.webkit.org/show_bug.cgi?id=185205

Attachment 339344: Patch

https://bugs.webkit.org/attachment.cgi?id=339344&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 339344
  --> https://bugs.webkit.org/attachment.cgi?id=339344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339344&action=review

> Source/WebCore/platform/mac/PasteboardMac.mm:202
> -	   paths.append(pasteboardURL.title.stripWhiteSpace());
> +	   paths.append([title stringByTrimmingCharactersInSet:[NSCharacterSet
whitespaceCharacterSet]]);

We should probably just use our stripWhiteSpace, not Cocoa’s. You’re going to
turn it into a String soon anyway, might as well do it before that step and use
more WebKit code.

> Tools/TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:116
> +    urls = [WebURLsWithTitles URLsFromPasteboard: [NSPasteboard
generalPasteboard]];

No spaces after colons.