[webkit-reviews] review granted: [Bug 185210] Use RetainPtr for form input type : [Attachment 339328] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 185210: Use RetainPtr for form input type
https://bugs.webkit.org/show_bug.cgi?id=185210

Attachment 339328: Patch

https://bugs.webkit.org/attachment.cgi?id=339328&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339328
  --> https://bugs.webkit.org/attachment.cgi?id=339328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339328&action=review

> Source/WebCore/html/HTMLInputElement.cpp:130
> -    , m_inputType(createdByParser ? nullptr : InputType::createText(*this))
> +    , m_inputType(createdByParser ? RefPtr<InputType>() :
InputType::createText(*this))

We can't use nullptr here!?
Alternatively, you can just assign in the constructor body instead.