[webkit-reviews] review granted: [Bug 184892] Use NetworkLoadChecker for navigation loads : [Attachment 339145] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 184892: Use NetworkLoadChecker for navigation loads
https://bugs.webkit.org/show_bug.cgi?id=184892

Attachment 339145: Patch

https://bugs.webkit.org/attachment.cgi?id=339145&action=review




--- Comment #16 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339145
  --> https://bugs.webkit.org/attachment.cgi?id=339145
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339145&action=review

r=me

> Source/WebCore/platform/network/ResourceResponseBase.cpp:392
> +void ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingTainting()

I think AccordingToTainting sounds better.

> Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp:325
> +    // FIXME: Enable content blockers for navigation loads.

This would be a pretty bad regression so I do not think we should enable this
code path by default until this is supported.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:615
> +	   if (!newRequest.url().protocolIsInHTTPFamily() &&
!newRequest.url().protocolIs("about") && m_redirectCount) {

isBlankURL() ?

> Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:667
> +    return
RuntimeEnabledFeatures::sharedFeatures().restrictedHTTPResponseAccess();

This is still disabled by default, right?