[webkit-reviews] review granted: [Bug 185192] [JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64 : [Attachment 339295] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185192: [JSC] Add compareDouble and compareFloat for ARM64, X86, and X86_64
https://bugs.webkit.org/show_bug.cgi?id=185192

Attachment 339295: Patch

https://bugs.webkit.org/attachment.cgi?id=339295&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 339295
  --> https://bugs.webkit.org/attachment.cgi?id=339295
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339295&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:4162
> +	       return;

Let's make this a RELEASE_ASSERT_NOT_REACHED().