[webkit-reviews] review granted: [Bug 185188] [JSC] Add MacroAssembler::and16 and store16 : [Attachment 339289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 09:55:39 PDT 2018


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185188: [JSC] Add MacroAssembler::and16 and store16
https://bugs.webkit.org/show_bug.cgi?id=185188

Attachment 339289: Patch

https://bugs.webkit.org/attachment.cgi?id=339289&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 339289
  --> https://bugs.webkit.org/attachment.cgi?id=339289
Patch

Sorry, I didn't see this patch before I reviewed and r+'ed
https://bugs.webkit.org/show_bug.cgi?id=185196 and
https://bugs.webkit.org/show_bug.cgi?id=185195.

r+ anyway for Source/JavaScriptCore/assembler/MacroAssemblerARM.h part.  You'll
probably have to remove the ARMv7 and MIPS parts to resolve a conflict before
landing.


More information about the webkit-reviews mailing list