[webkit-reviews] review granted: [Bug 185138] [Curl] Add OpenSSL/LibreSSL multi-threading support : [Attachment 339279] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 2 07:03:49 PDT 2018


Per Arne Vollan <pvollan at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 185138: [Curl] Add OpenSSL/LibreSSL multi-threading support
https://bugs.webkit.org/show_bug.cgi?id=185138

Attachment 339279: fix

https://bugs.webkit.org/attachment.cgi?id=339279&action=review




--- Comment #10 from Per Arne Vollan <pvollan at apple.com> ---
Comment on attachment 339279
  --> https://bugs.webkit.org/attachment.cgi?id=339279
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=339279&action=review

R=me.

> Source/WebCore/platform/network/curl/CurlSSLHandle.cpp:144
> +    ASSERT(type >= 0 && type < CRYPTO_NUM_LOCKS);

I think we should use RELEASE_ASSERT here.


More information about the webkit-reviews mailing list