[webkit-reviews] review granted: [Bug 185065] [JSC] Add SameValue DFG node : [Attachment 339085] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185065: [JSC] Add SameValue DFG node
https://bugs.webkit.org/show_bug.cgi?id=185065

Attachment 339085: Patch

https://bugs.webkit.org/attachment.cgi?id=339085&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339085
  --> https://bugs.webkit.org/attachment.cgi?id=339085
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339085&action=review

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:2643
> +	   if (argumentCountIncludingThis != 3)

Why not < instead of !=?

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:6383
> +	   m_jit.compareDouble(CCallHelpers::DoubleNotEqualOrUnordered,
arg1FPR, arg1FPR, tempGPR);

Since this code branches internally, it feels like we should only do it if the
doubles aren’t bitwise equal