[webkit-reviews] review granted: [Bug 185175] Get the WebKit.framework bundle by asking for WKWebView : [Attachment 339246] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 17:22:54 PDT 2018


Tim Horton <thorton at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 185175: Get the WebKit.framework bundle by asking for WKWebView
https://bugs.webkit.org/show_bug.cgi?id=185175

Attachment 339246: Patch

https://bugs.webkit.org/attachment.cgi?id=339246&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 339246
  --> https://bugs.webkit.org/attachment.cgi?id=339246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339246&action=review

> Source/WebKit/StorageProcess/mac/StorageProcessMac.mm:57
> +    NSBundle *webKit2Bundle = [NSBundle
bundleForClass:NSClassFromString(@"WKWebView")];

Seems like this should be a helper somewhere very global, at some point (that’s
what other framework projects seem to do).


More information about the webkit-reviews mailing list