[webkit-reviews] review granted: [Bug 185169] Fix build error after r231194 : [Attachment 339220] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 1 13:27:12 PDT 2018
JF Bastien <jfbastien at apple.com> has granted GSkachkov <gskachkov at gmail.com>'s
request for review:
Bug 185169: Fix build error after r231194
https://bugs.webkit.org/show_bug.cgi?id=185169
Attachment 339220: Patch
https://bugs.webkit.org/attachment.cgi?id=339220&action=review
--- Comment #10 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 339220
--> https://bugs.webkit.org/attachment.cgi?id=339220
Patch
It's a bit weird to have it on the definition instead of the declaration (as
the warning complained), but it keeps the code simpler and seems to keep clang
happy (I just checked https://godbolt.org/g/iF3sMd). So r=me
More information about the webkit-reviews
mailing list