[webkit-reviews] review denied: [Bug 184926] Auto save the results for Test262 : [Attachment 338797] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 1 13:17:32 PDT 2018


Michael Saboff <msaboff at apple.com> has denied Leo Balter
<leonardo.balter at gmail.com>'s request for review:
Bug 184926: Auto save the results for Test262
https://bugs.webkit.org/show_bug.cgi?id=184926

Attachment 338797: Patch

https://bugs.webkit.org/attachment.cgi?id=338797&action=review




--- Comment #5 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 338797
  --> https://bugs.webkit.org/attachment.cgi?id=338797
Patch

r- for the moving the results and expectations to JSTestt

This should done as two patches.
 - The first patch to save the result.
 - A second patch to move things around.
I would approve the first patch.  I don't like having the test script in
Tests/Scripts and the output in JSTests.  I think it does make sense to move
both the runner and output files to JSTests.  That may require some rework of
the current JSTests/test262 layout.


More information about the webkit-reviews mailing list