[webkit-reviews] review granted: [Bug 185167] Protect against changes to CoreMedia function signatures : [Attachment 339205] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 185167: Protect against changes to CoreMedia function signatures
https://bugs.webkit.org/show_bug.cgi?id=185167

Attachment 339205: Patch

https://bugs.webkit.org/attachment.cgi?id=339205&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 339205
  --> https://bugs.webkit.org/attachment.cgi?id=339205
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339205&action=review

> Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp:42
> +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED <= 120000) ||
(PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101400)
> +#define CMSAMPLEBUFFERCALL_NOESCAPE
> +#else
> +#define CMSAMPLEBUFFERCALL_NOESCAPE CF_NOESCAPE
> +#endif

Why define this here and in the .h file?