[webkit-reviews] review granted: [Bug 185159] Use default std::optional if it is provided : [Attachment 339197] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185159: Use default std::optional if it is provided
https://bugs.webkit.org/show_bug.cgi?id=185159

Attachment 339197: Patch

https://bugs.webkit.org/attachment.cgi?id=339197&action=review




--- Comment #11 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 339197
  --> https://bugs.webkit.org/attachment.cgi?id=339197
Patch

Hmm the segfaults are annoying :(
I want to make sure we don't break Linux builds. Can you confirm that it works
locally for you?

I started a patch yesterday to turn C++17 on in the Xcode build settings, will
finish it later today (have a meeting now...). I think landing your patch first
would be good because it'll simplify what I need to do, so assuming bots are
happy r=me