[webkit-reviews] review requested: [Bug 184121] bmalloc should compute its own estimate of its footprint : [Attachment 336916] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 30 23:15:47 PDT 2018


Saam Barati <sbarati at apple.com> has asked  for review:
Bug 184121: bmalloc should compute its own estimate of its footprint
https://bugs.webkit.org/show_bug.cgi?id=184121

Attachment 336916: patch

https://bugs.webkit.org/attachment.cgi?id=336916&action=review




--- Comment #8 from Saam Barati <sbarati at apple.com> ---
Created attachment 336916

  --> https://bugs.webkit.org/attachment.cgi?id=336916&action=review

patch

I still need to do some performance testing on iOS. The footprint measurement
is accurate, but unlike phys_footprint, it doesn't account for compressed
memory on iOS. This means I may need to tune some of our isUnderMemoryPressure
heuristics to account for the change in measurement.


More information about the webkit-reviews mailing list