[webkit-reviews] review granted: [Bug 184175] Add pointer profiling support to Wasm. : [Attachment 336842] proposed patch.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 184175: Add pointer profiling support to Wasm.
https://bugs.webkit.org/show_bug.cgi?id=184175

Attachment 336842: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=336842&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 336842
  --> https://bugs.webkit.org/attachment.cgi?id=336842
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336842&action=review

r=me this is great! :D

> Source/JavaScriptCore/wasm/js/WebAssemblyFunction.h:72
> +	   return m_jsEntrypoint.retagged(CodeEntryPtrTag,
CodeEntryWithArityCheckPtrTag);

Right now vmEntryToWebAssembly is the same thing as vmEntryToJavaScript. Should
we split them and use different CodeEntryPtrTag?