[webkit-reviews] review granted: [Bug 184170] Remove WTF_EXPORTDATA and JS_EXPORTDATA : [Attachment 336833] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 29 19:52:45 PDT 2018
JF Bastien <jfbastien at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 184170: Remove WTF_EXPORTDATA and JS_EXPORTDATA
https://bugs.webkit.org/show_bug.cgi?id=184170
Attachment 336833: Patch
https://bugs.webkit.org/attachment.cgi?id=336833&action=review
--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 336833
--> https://bugs.webkit.org/attachment.cgi?id=336833
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=336833&action=review
Hehe I was going to do that next :)
r=me with a tiny nit.
> Source/JavaScriptCore/runtime/JSCell.h:73
> + static JS_EXPORT_PRIVATE const ::JSC::ClassInfo s_info;
\
Messed up alignment here :)
More information about the webkit-reviews
mailing list