[webkit-reviews] review granted: [Bug 184117] run-jsc-benchmarks should recognize Windows-style build directory structure. : [Attachment 336733] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 184117: run-jsc-benchmarks should recognize Windows-style build directory
structure.
https://bugs.webkit.org/show_bug.cgi?id=184117

Attachment 336733: Patch

https://bugs.webkit.org/attachment.cgi?id=336733&action=review




--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 336733
  --> https://bugs.webkit.org/attachment.cgi?id=336733
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336733&action=review

r=me with some nits

> Tools/Scripts/run-jsc-benchmarks:1345
> +    elsif @path =~ /\/Release\/bin(64|32|)\/([.a-zA-Z]+)$/

I think `[.a-zA-Z]` should be `[\.a-zA-Z]`.

> Tools/Scripts/run-jsc-benchmarks:1347
> +    elsif @path =~ /\/Debug\/bin(64|32|)\/([.a-zA-Z]+)$/

Ditto.