[webkit-reviews] review denied: [Bug 184120] [Win] MSVC can't compile WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent : [Attachment 336745] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 184120: [Win] MSVC can't compile
WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent
https://bugs.webkit.org/show_bug.cgi?id=184120

Attachment 336745: Patch

https://bugs.webkit.org/attachment.cgi?id=336745&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 336745
  --> https://bugs.webkit.org/attachment.cgi?id=336745
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336745&action=review

> Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:824
> -	       grandfatherExistingWebsiteData([protectedThis = makeRef(*this),
callback = WTFMove(callback)]() {
> +	       grandfatherExistingWebsiteData([protectedThis =
protectedThis.copyRef(), callback = WTFMove(callback)]() {

protectedThis = WTFMove(protectedThis)
There's no need to unnecessarily increment and decrement the ref count twice in
this case.