[webkit-reviews] review granted: [Bug 184137] ArrayMode should not try to get the DFG to think it can convert TypedArrays : [Attachment 336779] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 184137: ArrayMode should not try to get the DFG to think it can convert
TypedArrays
https://bugs.webkit.org/show_bug.cgi?id=184137

Attachment 336779: Patch

https://bugs.webkit.org/attachment.cgi?id=336779&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 336779
  --> https://bugs.webkit.org/attachment.cgi?id=336779
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336779&action=review

maybe add a microbenchmark?

> Source/JavaScriptCore/dfg/DFGArrayMode.cpp:121
> +	   // If we have seen multiple TypedArray types or a TypedArray and
non-typed array it doesn't make sense to try to convert the array since we
won't be able to when we have a typed array.

"If we have seen multiple TypedArray types or a TypedArray and non-typed array
it doesn't make sense to try to convert the array since we won't be able to
when we have a typed array." =>
"If we have seen multiple TypedArray types, or a TypedArray and non-typed
array, it doesn't make sense to try to convert the array since you can't
convert typed arrays."