[webkit-reviews] review granted: [Bug 183959] Add compile guard for blocking of the WindowServer in the WebProcess. : [Attachment 336689] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183959: Add compile guard for blocking of the WindowServer in the
WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=183959

Attachment 336689: Patch

https://bugs.webkit.org/attachment.cgi?id=336689&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 336689
  --> https://bugs.webkit.org/attachment.cgi?id=336689
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336689&action=review

This seems reasonable. Please add a log statement before landing.

> Source/WebKit/ChangeLog:3
> +	   Add compile guard for blocking of the WindowServer in the
WebProcess.

When I read this, I though you were reading a new compile macro -- but you are
just using it. I think I'd title this, "Adopt WEBPROCESS_WINDOWSERVER_BLOCKING
compiler guard in WebProcess", or something.

> Source/WebKit/WebProcess/WebProcess.cpp:234
> +    ASSERT_UNUSED(error, error == kCGErrorSuccess);

I think you should log an error here if we are unsuccessful in calling
DenyWindowServerConnections.