[webkit-reviews] review denied: [Bug 184062] MSVC __forceinline slows down JSC release build fivefold after r229391 : [Attachment 336631] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 184062: MSVC __forceinline slows down JSC release build fivefold after
r229391
https://bugs.webkit.org/show_bug.cgi?id=184062

Attachment 336631: Patch

https://bugs.webkit.org/attachment.cgi?id=336631&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 336631
  --> https://bugs.webkit.org/attachment.cgi?id=336631
Patch

I agree with JF that this is too drastic a change.  I think we should instead
do something like I needed to do in
https://bugs.webkit.org/show_bug.cgi?id=125808 and only remove the
__forceinline on only the problematic inlines.	There are a lot of instances of
ALWAYS_INLINE that we probably want to keep.