[webkit-reviews] review granted: [Bug 184077] [Web Animations] Implement more CSSPropertyBlendingClient methods : [Attachment 336655] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 184077: [Web Animations] Implement more CSSPropertyBlendingClient methods
https://bugs.webkit.org/show_bug.cgi?id=184077

Attachment 336655: Patch

https://bugs.webkit.org/attachment.cgi?id=336655&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 336655
  --> https://bugs.webkit.org/attachment.cgi?id=336655
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336655&action=review

Shouldn't we be copying all these tests into a new directory, and have that
version include the flag to use Web Animations? Otherwise we're only testing
one of the code paths.

>>> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:733
>>> +	     // An emtpy transform list matches anything.
>> 
>> Typo empty x 3
>> 
>> Is there a way to unify these matching implementations
> 
> I blame whoever wrote that code originally :)

50% chance it was me.