[webkit-reviews] review granted: [Bug 184069] Enhance ARM64 probe to support pointer profiling. : [Attachment 336639] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 21:37:28 PDT 2018


JF Bastien <jfbastien at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 184069: Enhance ARM64 probe to support pointer profiling.
https://bugs.webkit.org/show_bug.cgi?id=184069

Attachment 336639: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=336639&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 336639
  --> https://bugs.webkit.org/attachment.cgi?id=336639
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=336639&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2146
> +    }

Assert that the registers aren't the same?


More information about the webkit-reviews mailing list