[webkit-reviews] review granted: [Bug 184047] Web Inspector: Modernize some utility functions : [Attachment 336593] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 184047: Web Inspector: Modernize some utility functions
https://bugs.webkit.org/show_bug.cgi?id=184047

Attachment 336593: Patch

https://bugs.webkit.org/attachment.cgi?id=336593&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 336593
  --> https://bugs.webkit.org/attachment.cgi?id=336593
Patch

r=me, nice cleanup.

It would be good to get our utilities test coverage to 100% at some point, so
this can of refactoring can be done with greater confidence. Tests for
enclosingNodeOrSelfWithClass, enclosingNodeOrSelfWithNodeNameInArray, and
escapeCharacters would be nice to include before landing.