[webkit-reviews] review granted: [Bug 184044] Further refine cookie read/write logging : [Attachment 336594] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 184044: Further refine cookie read/write logging
https://bugs.webkit.org/show_bug.cgi?id=184044

Attachment 336594: Patch

https://bugs.webkit.org/attachment.cgi?id=336594&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 336594
  --> https://bugs.webkit.org/attachment.cgi?id=336594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336594&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:743
> +static String escapeIDForJSON(std::optional<uint64_t> value)

I would use a const & here.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:840
> +void NetworkResourceLoader::logCookieInformation(const String& label, const
void* loggedObject, const WebCore::NetworkStorageSession&
networkStorageSession, const WebCore::URL& firstParty, const WebCore::URL& url,
const String& referrer, std::optional<uint64_t> frameID,
std::optional<uint64_t> pageID, std::optional<uint64_t> identifier)

WebCore:: is not needed.

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:847
> +	   auto partition = WebCore::URL(ParsedURLString,
networkStorageSession.cookieStoragePartition(firstParty, url, frameID,
pageID));

WebCore:: is not needed.