[webkit-reviews] review granted: [Bug 183865] Move request checking out of PingLoad for future reuse in NetworkLoad : [Attachment 336383] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 09:34:47 PDT 2018


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 183865: Move request checking out of PingLoad for future reuse in
NetworkLoad
https://bugs.webkit.org/show_bug.cgi?id=183865

Attachment 336383: Patch

https://bugs.webkit.org/attachment.cgi?id=336383&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 336383
  --> https://bugs.webkit.org/attachment.cgi?id=336383
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336383&action=review

r=me with tiny nit.

> Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h:50
> +    enum class Result { Success, Failure, Cancelled };

We prefer Canceled with 1 'l'.


More information about the webkit-reviews mailing list