[webkit-reviews] review granted: [Bug 181939] AudioBufferSourceNode start method causes OfflineAudioContext to start running : [Attachment 336527] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 27 08:52:00 PDT 2018


Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 181939: AudioBufferSourceNode start method causes OfflineAudioContext to
start running
https://bugs.webkit.org/show_bug.cgi?id=181939

Attachment 336527: Patch

https://bugs.webkit.org/attachment.cgi?id=336527&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 336527
  --> https://bugs.webkit.org/attachment.cgi?id=336527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336527&action=review

> LayoutTests/webaudio/offlineaudiocontext-restriction.html:18
> +var calledResumeWithUserGesture = false;

Nit: this isn't used.


More information about the webkit-reviews mailing list