[webkit-reviews] review granted: [Bug 183987] [JSC] Remove repeated iteration of ElementNode : [Attachment 336486] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183987: [JSC] Remove repeated iteration of ElementNode
https://bugs.webkit.org/show_bug.cgi?id=183987

Attachment 336486: Patch

https://bugs.webkit.org/attachment.cgi?id=336486&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 336486
  --> https://bugs.webkit.org/attachment.cgi?id=336486
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336486&action=review

r=me with some nits.

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:398
> +    auto newArray = [&generator] (RegisterID* dst, ElementNode* elements,
unsigned length, bool hadVariableExpression) {

Nit: Why not just capture the args you're using?

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:418
> +		   if (!!node->elision()) {

Nit: You don't need the !!.