[webkit-reviews] review granted: [Bug 183655] JIT callOperation() needs to support operations that return SlowPathReturnType differently on Windows. : [Attachment 336331] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 183655: JIT callOperation() needs to support operations that return
SlowPathReturnType differently on Windows.
https://bugs.webkit.org/show_bug.cgi?id=183655

Attachment 336331: Patch

https://bugs.webkit.org/attachment.cgi?id=336331&action=review




--- Comment #20 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 336331
  --> https://bugs.webkit.org/attachment.cgi?id=336331
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336331&action=review

r=me with some nits.

> Source/JavaScriptCore/jit/JIT.h:753
> +#else

Nit: please comment what #if you are ending e.g. // OS(WINDOWS) && CPU(X86_64)

> Source/JavaScriptCore/jit/JIT.h:760
> +#endif

Ditto.

> Source/JavaScriptCore/jit/JITOperations.h:263
> +typedef SlowPathReturnType (JIT_OPERATION *Sprt_JITOperation_EZ)(ExecState*,
uint32_t);

This should be changed to: Sprt_JITOperation_EUi